Skip to content

Get phpcs to run without error #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itismadness wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Get phpcs to run without error #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions phpcs.xml
View file
Open in desktop

@recanman recanman Feb 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably is a better idea not to exclude the phpcs rules and fix those separately.

@itismadness itismadness Feb 6, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on what you want out of phpcs until the rule violations are fixed. Do you want the output of phpcs to continue to be largely ignored until all violations are fixed, or do you want it to be listened to for the rules that are working fine atm, while slowly fixing the excluded rules over subsequent PRs. My preference would be for the former.

Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,22 @@
<description>PHPCS configuration file.</description>

<file>src</file>
<file>tests</file>
<!--<file>tests</file>-->

<rule ref="PSR12"/>
<rule ref="PSR12">
<exclude name="Generic.Files.LineLength.TooLong" />
<exclude name="PEAR.Functions.ValidDefaultValue.NotAtEnd" />
<exclude name="PSR1.Classes.ClassDeclaration.MultipleClasses" />
<exclude name="PSR1.Methods.CamelCapsMethodName.NotCamelCaps" />
<exclude name="PSR2.Classes.PropertyDeclaration.ScopeMissing" />
<exclude name="PSR2.ControlStructures.SwitchDeclaration.TerminatingComment" />
<exclude name="PSR2.Methods.MethodDeclaration.Underscore" />
<exclude name="Squiz.Classes.ValidClassName.NotCamelCaps" />
<exclude name="Squiz.Scope.MethodScope.Missing" />
</rule>

<!--
<exclude-pattern>tests/reports</exclude-pattern>
<exclude-pattern>tests/_data</exclude-pattern>

</ruleset>
-->
</ruleset>
Loading