Skip to content

chore: remove redundant words in comment - #4476

Merged
tobtoht merged 1 commit into
monero-project:masterfrom
xihuwenhua:master
Aug 22, 2025
Merged

chore: remove redundant words in comment#4476
tobtoht merged 1 commit into
monero-project:masterfrom
xihuwenhua:master

Conversation

@xihuwenhua

Copy link
Copy Markdown
Contributor

remove redundant words in comment

@tobtoht

tobtoht commented Jul 22, 2025

Copy link
Copy Markdown
Collaborator

Please use unix line endings.

@nahuhh

nahuhh commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

@tobtoht its a bot :P

should be add autolf to .gitattributes?

edit: how did you spot the crlf endings? Locally?
edit2: nvm, it shows on git show

Signed-off-by: xihuwenhua <xihuwenhua@outlook.com>
@xihuwenhua

Copy link
Copy Markdown
Contributor Author

@tobtoht its a bot :P

should be add autolf to .gitattributes?

edit: how did you spot the crlf endings? Locally? edit2: nvm, it shows on git show

Not a bot 😅

@xihuwenhua

Copy link
Copy Markdown
Contributor Author

Please use unix line endings.

Thanks for your review.

I executed dos2unix WizardCreateWallet2.qml and resubmitted.

@tobtoht

tobtoht commented Aug 22, 2025

Copy link
Copy Markdown
Collaborator

Please also fix installers/windows/Deterministic.md.

@xihuwenhua

xihuwenhua commented Aug 22, 2025

Copy link
Copy Markdown
Contributor Author

Please also fix installers/windows/Deterministic.md.

Modified. Please review it when you have time.

image

@tobtoht

tobtoht commented Aug 22, 2025

Copy link
Copy Markdown
Collaborator

Please also fix installers/windows/Deterministic.md.

Never mind, sorry, the entire file uses CRLF... Force push 9e37b21 again and I'll merge it.

@xihuwenhua

Copy link
Copy Markdown
Contributor Author

Please also fix installers/windows/Deterministic.md.

Never mind, sorry, the entire file uses CRLF... Force push 9e37b21 again and I'll merge it.

No matter. I execute git reset --hard 9e37b21 and git push -f

image

Please review.

@tobtoht
tobtoht merged commit 346d962 into monero-project:master Aug 22, 2025
14 of 16 checks passed
@xihuwenhua

Copy link
Copy Markdown
Contributor Author

Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants