feat: add maxTimeMS support to the database tools COMPASS-10235#8020
Open
feat: add maxTimeMS support to the database tools COMPASS-10235#8020
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for propagating Compass’ maxTimeMS preference into the MCP/database tool runner configuration so db-read tool calls can respect operation time limits.
Changes:
- Extend the tools context/config to include optional
maxTimeMSand pass it intoUserConfigSchema. - Keep
runner.userConfig.maxTimeMSin sync whenToolsController.setContext()is called. - Plumb
prefs.maxTimeMSthrough the Compass Assistant provider and update related unit tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/compass-generative-ai/src/tools-controller.ts | Adds maxTimeMS to tools context/config and syncs it to MCP runner userConfig. |
| packages/compass-generative-ai/src/tools-controller.spec.ts | Adds a unit test verifying maxTimeMS sync behavior in setContext(). |
| packages/compass-assistant/src/compass-assistant-provider.tsx | Passes prefs.maxTimeMS into the tools context setup. |
| packages/compass-assistant/src/compass-assistant-provider.spec.tsx | Updates expectations to include the new maxTimeMS field in setContext() calls. |
mabaasit
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPASS-10235