feat(devtools-connect): revert "fail fast on specific error and codes from compass-web COMPASS-9793 (#592)"#684
Open
feat(devtools-connect): revert "fail fast on specific error and codes from compass-web COMPASS-9793 (#592)"#684
Conversation
… from compass-web and add useSystemCA to public options COMPASS-9793 (#592)" This reverts commit 242f0d1.
nbbeeken
commented
Apr 16, 2026
| /** | ||
| * Whether to use the system certificate store. Defaults to `true`. | ||
| */ | ||
| useSystemCA?: boolean; |
Collaborator
Author
There was a problem hiding this comment.
This was intended to be used in compass-web, but never was.... ugh, semver? :(
I'm sorry for my mess.
Collaborator
Author
There was a problem hiding this comment.
Notably not reverted:
- this unused variable still exported: COMPASS_SOCKET_SERVICE_NON_RETRY_CODES
useSystemCAoption logic still there, not the worse feat to have hanging around
|
coverage: 78.237% (-0.08%) from 78.318% — revert-242f0d1 into main |
nbbeeken
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 242f0d1.
Description
There's no point in the web specific errors being here anymore and the logic to make devtools-connect usable on web is not needed
Open Questions
Checklist