fix: undefined query should work like null query VSCODE-774

[lerouxb]

VSCODE-774

[Copilot]

Pull request overview

This PR addresses VSCODE-774 by treating an undefined query value the same as a null query value when determining whether the document browsing view should behave as a “basic query” view.

Changes:

• Updated isBasicQuery to return true when state.query is undefined as well as null.
• Added a unit test covering the query === undefined case.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/views/data-browsing-app/store/documentQuerySlice.ts	Expands the “basic query” condition to include undefined query values.
src/test/suite/views/data-browsing-app/documentQuerySlice.test.tsx	Adds test coverage for isBasicQuery when query is undefined.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Anemy]

I might rename isBasicQuery to something like isEmptyFindResult or something, that's a bit of a nit and unrelated, fine as is. The copilot comment is something we likely want to fix, the type gaurd isn't correct anymore.

[lerouxb]

It isn't empty finds, though. That's still a cursor. By basic I mean is not a cursor. Could have checked the inverse too, though.

[lerouxb]

The real bug is that some things deserialize to undefined and it should be either a ServiceProviderQuery or null