Skip to content

tests(NODE-7533): pin NPM version & provide new configuration option to TS6 compiler#882

Merged
PavelSafronov merged 1 commit intomainfrom
NODE-7533
Apr 21, 2026
Merged

tests(NODE-7533): pin NPM version & provide new configuration option to TS6 compiler#882
PavelSafronov merged 1 commit intomainfrom
NODE-7533

Conversation

@tadjik1
Copy link
Copy Markdown
Member

@tadjik1 tadjik1 commented Apr 21, 2026

Description

Summary of Changes

Apply 2 small patches: pin NPM version on node22 to the version which it can upgrade itself into. Add new flag for running check on TS6 (which is both next and latest at the moment).

What is the motivation for this change?

Broken CI on Node22 & with TS6

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 marked this pull request as ready for review April 21, 2026 12:34
@tadjik1 tadjik1 requested a review from a team as a code owner April 21, 2026 12:34
Copilot AI review requested due to automatic review settings April 21, 2026 12:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Evergreen CI configuration to stabilize Node 22 runs by pinning npm and to support TypeScript 6 “consumer-style” checks by allowing additional tsc flags to be passed through.

Changes:

  • Pin NPM_VERSION for the Node 22 Evergreen task.
  • Add TSC_EXTRA_FLAGS plumbing through Evergreen and use it when invoking tsc in the TypeScript check script.
  • Switch the “next” TypeScript check to TS_VERSION: "next" and pass --ignoreConfig to avoid inheriting the repo tsconfig.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.evergreen/run-typescript.sh Passes optional extra flags to tsc invocations to support TS6-specific behavior.
.evergreen/config.yml Pins npm for Node 22, adds TSC_EXTRA_FLAGS env wiring, and updates the TS “next” task to use TS next + --ignoreConfig.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .evergreen/config.yml
Comment thread .evergreen/run-typescript.sh
@PavelSafronov PavelSafronov self-assigned this Apr 21, 2026
@PavelSafronov PavelSafronov added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 21, 2026
@PavelSafronov PavelSafronov merged commit 913073d into main Apr 21, 2026
13 checks passed
@PavelSafronov PavelSafronov deleted the NODE-7533 branch April 21, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants