TOOLS-4263 Delete JS tests fully covered by existing Go tests#1041
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 16, 2026
autarch
force-pushed
the
07-16-tools-4263_delete_js_tests_fully_covered_by_existing_go_tests
branch
from
July 16, 2026 20:35
75c4e40 to
eef4eab
Compare
autarch
changed the base branch from
graphite-base/1041
to
07-16-tools-4263_add_a_go_test_that_we_preserve_indexes_when_restoring_with_a_non-admin_user_on_a_per-data_basis
July 16, 2026 20:35
Here's a mapping of JS to existing Go tests:
- test/legacy42/jstests/tool/tool1.js
-> TestRoundTripBasicData (integration/exportimport/data_test.go)
+ TestPipedDumpRestore (integration/dumprestore/roundtrip_test.go)
- test/legacy42/jstests/tool/exportimport3.js
-> TestRoundTripJSONArray (integration/exportimport/json_test.go)
- test/legacy42/jstests/tool/restorewithauth.js
-> TestDumpRestoreEnforcesAuthRoles (mongorestore/dumprestore_auth_test.go)
- test/qa-tests/jstests/restore/users_and_roles_admin.js
-> TestDumpRestoreSingleDBWithDBUsersAndRoles (mongorestore/dumprestore_auth_test.go)
- test/qa-tests/jstests/restore/stop_on_error.js
-> TestMongorestoreMIOSOE (mongorestore/mongorestore_test.go)
- test/qa-tests/jstests/restore/oplog_replay_specify_file.js
-> TestOplogRestore and related oplog-file cases (mongorestore/oplog_test.go)
- test/qa-tests/jstests/import/stoponerror.js
-> TestImportMIOSOE (mongoimport/mongoimport_test.go)
- test/qa-tests/jstests/files/mongofiles_list.js
-> "list" cases in TestMongoFilesCommands (mongofiles/mongofiles_test.go)
autarch
force-pushed
the
07-16-tools-4263_add_a_go_test_that_we_preserve_indexes_when_restoring_with_a_non-admin_user_on_a_per-data_basis
branch
from
July 17, 2026 18:57
2a490be to
ae8464d
Compare
autarch
force-pushed
the
07-16-tools-4263_delete_js_tests_fully_covered_by_existing_go_tests
branch
from
July 17, 2026 18:57
eef4eab to
47590df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a mapping of JS to existing Go tests:
-> TestRoundTripBasicData (integration/exportimport/data_test.go)
+ TestPipedDumpRestore (integration/dumprestore/roundtrip_test.go)
-> TestRoundTripJSONArray (integration/exportimport/json_test.go)
-> TestDumpRestoreEnforcesAuthRoles (mongorestore/dumprestore_auth_test.go)
-> TestRestoreWithDBUserPreservesIndexes (mongorestore/dumprestore_auth_test.go)
-> TestDumpRestoreSingleDBWithDBUsersAndRoles (mongorestore/dumprestore_auth_test.go)
-> TestMongorestoreMIOSOE (mongorestore/mongorestore_test.go)
-> TestOplogRestore and related oplog-file cases (mongorestore/oplog_test.go)
-> TestImportMIOSOE (mongoimport/mongoimport_test.go)
-> "list" cases in TestMongoFilesCommands (mongofiles/mongofiles_test.go)