Conversation
mikwat
reviewed
Jan 18, 2018
mikwat
left a comment
mikwat
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this, but I understand your concern.
| track_history :on => [:embedded_relations] # all embedded relations will be tracked | ||
| track_history :on => [ | ||
| :embedded_relations, | ||
| :rereferenced_relations |
Contributor
There was a problem hiding this comment.
Typo? Should be :referenced_relations
| before_add: :track_references, | ||
| before_remove: :track_references | ||
| }.merge(opts) | ||
| end |
Contributor
There was a problem hiding this comment.
Interesting idea! Does feel like a bit of a hack though...
|
Status update for this ? |
Collaborator
Author
|
I haven't made progress on it and probably won't any time soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #215.
@mikwat Check this out? I find the overwriting of
has_and_belongs_to_manyvery ugly and the whole code here feels a lot like a hack.Also I bet undo, redo and such don't work in these scenarios, needs specs.