Skip to content

Fixes for #244 and #245 - #246

Open
vanboom wants to merge 4 commits into
mongoid:masterfrom
vanboom:master
Open

vanboom wants to merge 4 commits into
mongoid:masterfrom
vanboom:master

Conversation

@vanboom

@vanboom vanboom commented Jul 22, 2020

Copy link
Copy Markdown

#244 - allow the tracker to track embedded relations

#245 - handle nil original value for an embeds_many relation

@mongoid-bot

mongoid-bot commented Jul 22, 2020

Copy link
Copy Markdown
2 Warnings
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#246](https://github.com/mongoid/mongoid-history/pull/246): Fixes for #244 and #245 - [@vanboom](https://github.com/vanboom).

Generated by 🚫 danger

@dblock

dblock commented Jul 23, 2020

Copy link
Copy Markdown
Collaborator

Thanks, this needs tests and changelog, please.

@dblock

dblock commented Sep 22, 2020

Copy link
Copy Markdown
Collaborator

Bump?

@johnnyshields

Copy link
Copy Markdown
Member

#244 looks suspect, the line should not be removed. I'll take a look later at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants