fix: prevent CastError being triggered by literal NaN#16
Open
jdbdnz wants to merge 2 commits intomongoosejs:masterfrom
Open
fix: prevent CastError being triggered by literal NaN#16jdbdnz wants to merge 2 commits intomongoosejs:masterfrom
jdbdnz wants to merge 2 commits intomongoosejs:masterfrom
Conversation
Updates from trunk
Author
|
I could see a case being made for removing the CastError entirely; instead writing non-numbers as |
Author
|
@vkarpov15 are you interested in this change, or should I close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
NaNis a valid value in MongoDB for Number type attributes (i.e. doubles). This change is necessary to avoid superfluous errors when loading records withNaNvalues in number fields.Previous behavior:
"harold"=>CastErrorNaN=>CastError1=> no errorNew behavior:
"harold"=>CastErrorNaN=> no error1=> no errorChanges
CastErrorto throw for anything which resolves to a NaN, but not for literalNaNsThoughts
I think the decision to accept
NaNas a valid number type in MongoDB is dubious, I don't see a valid reason for wanting to store it. That said, the world is imperfect and so is the data we deal with.My judgement here is that it is better to handle the imperfections gracefully. Feel free to close if you don't agree, and I'll just keep using my fork.