Conversation
…idn't have populate() Fix #79 Re: Automattic/mongoose#10816
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #79 by modifying how populate virtuals are handled so that unpopulated virtuals remain undefined instead of being set to default empty values. It also adds test cases for both populated and unpopulated virtuals to ensure the behavior of lean() matches that of toObject().
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/index.test.js | Added tests verifying that unpopulated virtuals resolve to undefined and populated virtuals default to an empty array when appropriate. |
| index.js | Removed the code that unnecessarily set default values on populated virtuals, along with the helper function isPopulateVirtual. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #79
Re: Automattic/mongoose#10816
Summary
Thanks for reporting. We originally added this behavior in a9a8daa for Automattic/mongoose#10816, but this behavior looks to be no longer necessary.
Examples