Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for the retry mechanism when an in-progress task times out and has a non-zero retryOnTimeoutCount value. The test ensures that the expired task transitions to timed_out status and a new retry task is created with proper field resets and counter decrementation.
Key changes:
- Adds new test case
creates a retry task when a timed out task has retryOnTimeoutCountintest/task.test.js - Verifies retry task creation with decremented
retryOnTimeoutCount(from 2 to 1) - Validates runtime fields are cleared and scheduling fields are properly set
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
retryOnTimeoutCountso a retry task is created.Description
test/task.test.jsnamedcreates a retry task when a timed out task has retryOnTimeoutCountthat simulates an expiredin_progresstask and callsTask.expireTimedOutTasks().timed_outand that a new pending retry task is created withretryOnTimeoutCountdecremented.startedRunningAt,finishedRunningAt,workerName,timeoutAt,error,result) and retains the originalscheduledAtandparams.schedulingTimeoutAtis set tonow.valueOf() + 10 * 60 * 1000as expected by the expiry logic.Testing
test/task.test.jsand commits it to the branch.Codex Task