feat: validate false positive rate on real production traffic in CI - #454
Open
monperrus wants to merge 2 commits into
Open
feat: validate false positive rate on real production traffic in CI#454monperrus wants to merge 2 commits into
monperrus wants to merge 2 commits into
Conversation
The pattern "Silk\/" was matching Amazon Silk browser UAs (e.g. "Mozilla/5.0 ... Silk/138.x like Chrome/..."). The actual crawler UA starts with "Silk/" so anchoring with "^" fixes the false positive. Fixes #449 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds validate_false_positives.py which downloads the top_user_agents dataset from mwnciau/user_agent_dumps, measures the weighted false positive rate on non-bot traffic, and fails if it exceeds 1%. Closes #438 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #438
What
Adds
validate_false_positives.pyand wires it into CI (ci-validation.yml).The script:
top_user_agentsdataset from mwnciau/user_agent_dumps (2 086 real-world UAs, weighted by request count, with anisBotfield).isBot: false).Example output