This repository was archived by the owner on Sep 9, 2024. It is now read-only.
🗞️ Only allocate pointers when we are ready to set/use the result#51
Open
suhailpatel wants to merge 2 commits into
Open
🗞️ Only allocate pointers when we are ready to set/use the result#51suhailpatel wants to merge 2 commits into
suhailpatel wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you pass a pointer to an address that is nil, we do some allocation. Right now this happens at the top of the function so we didn't have to worry about it.
This PR changes that behaviour slightly to allocate right before we are ready to set (and after some errors have been handled). In gocassa v2.0.0, this behaviour was undefined but there are users who were relying on the result value/pointer being untouched (unallocated in the nil case) in the case of an error. Also adds a test to make sure we don't have a future regression.