Adds method to migrate operators from existing middlewares.#5
Adds method to migrate operators from existing middlewares.#5steven2308 wants to merge 1 commit intomainfrom
Conversation
This will be needed to register symbiotic operators the first time meta middleware is deployed. It can be removed afterwards.
| address[] calldata operators, | ||
| bytes32[] memory keys, | ||
| address middleware | ||
| ) external onlyRole(DEFAULT_ADMIN_ROLE) onlyKnownMiddleware(middleware) { |
There was a problem hiding this comment.
I thought this was going to get called directly by the middleware? Why by the admin? It would make sense to do everything on chain from the middleware and make those onlyRole admin
There was a problem hiding this comment.
By doing this we don't even have to pass the address of th emiddleware, but we just check that the sender is a known middleware
NindoK
left a comment
There was a problem hiding this comment.
I'd rather do from each middleware rather than admin
I think you are missing the context of this task. This is to migrate. The rest of operations: register, unregister, update key, will call this directly. The methods for that already exist and must be called by the middlewares directly. |
This will be needed to register symbiotic operators the first time meta middleware is deployed.
It can be removed afterwards.