Skip to content

Fix: moon docker scaffold performance - #2010

Merged
milesj merged 2 commits into
moonrepo:masterfrom
aayushsinha44:fix-scaffold-perf
Jun 14, 2025
Merged

Fix: moon docker scaffold performance#2010
milesj merged 2 commits into
moonrepo:masterfrom
aayushsinha44:fix-scaffold-perf

Conversation

@aayushsinha44

@aayushsinha44 aayushsinha44 commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

Fix for issue
#2008

Currently moon docker scaffold command does a dependency graph traversal and copies the relevant files. But doesn't mark the node visited. Because of which same project gets processed twice i.e. copied twice.

We seen cases where this command takes more than 20 mins to run, where a single library gets copied over 105,000+ times. After this fix, the project now takes <30s for moon docker scaffold command to complete.

@milesj

milesj commented Jun 13, 2025

Copy link
Copy Markdown
Collaborator

@aayushsinha44 Looks good but you'll need to run just bump patch and commit the file.

@aayushsinha44

Copy link
Copy Markdown
Contributor Author

Thanks for the quick review @milesj. Pushed the jump bump patch file output`.

Also, may I know by when can we expect this to get released? This will help us improve our build time.

@milesj
milesj enabled auto-merge (squash) June 14, 2025 05:15
@milesj

milesj commented Jun 14, 2025

Copy link
Copy Markdown
Collaborator

Probably on monday, or tuesday the latest.

@milesj
milesj merged commit 80b20b6 into moonrepo:master Jun 14, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants