Fix: moon docker scaffold performance - #2010
Merged
Merged
Conversation
Collaborator
|
@aayushsinha44 Looks good but you'll need to run |
Contributor
Author
|
Thanks for the quick review @milesj. Pushed the Also, may I know by when can we expect this to get released? This will help us improve our build time. |
milesj
enabled auto-merge (squash)
June 14, 2025 05:15
Collaborator
|
Probably on monday, or tuesday the latest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue
#2008
Currently
moon docker scaffoldcommand does a dependency graph traversal and copies the relevant files. But doesn't mark the node visited. Because of which same project gets processed twice i.e. copied twice.We seen cases where this command takes more than 20 mins to run, where a single library gets copied over 105,000+ times. After this fix, the project now takes <30s for
moon docker scaffoldcommand to complete.