Closed
Fix CI plugin distribution overrides masking proto upgrade behavior#2549
Conversation
… fix CI race condition on Windows
Copilot
AI
changed the title
fix(plugin): add cross-process file lock for WASM plugin downloads to fix CI race on Windows
fix(plugin): serialize concurrent WASM plugin downloads with a cross-process file lock
Jun 2, 2026
Copilot created this pull request from a session on behalf of
milesj
June 2, 2026 06:12
View session
Copilot
AI
changed the title
fix(plugin): serialize concurrent WASM plugin downloads with a cross-process file lock
Fix CI plugin distribution overrides masking proto upgrade behavior
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failing
run_legacyjobs were not caused by the removed timeout vars; they were caused by CI still forcing debug/url-based plugin distribution across all Rust jobs while the CLI also coercedMOON_PLUGINS_USE_URL_DISTintoPROTO_PLUGINS_USE_URL_DIST=trueon mere presence. That combination masked the defaultghcr.iopath introduced by the proto/warpgate upgrade and made CI exercise the wrong bootstrap path.What changed
true.Why this matters
MOON_PLUGINS_USE_URL_DIST=falsewere still being converted intoPROTO_PLUGINS_USE_URL_DIST=true, making local behavior and CI behavior diverge.Behavioral change
MOON_PLUGINS_USE_URL_DISTforced proto into URL mode.