Skip to content

Fix CI plugin distribution overrides masking proto upgrade behavior - #2549

Closed
milesj with Copilot wants to merge 1 commit into
masterfrom
copilot/debug-ci-performance
Closed

Fix CI plugin distribution overrides masking proto upgrade behavior#2549
milesj with Copilot wants to merge 1 commit into
masterfrom
copilot/debug-ci-performance

Conversation

Copilot AI commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

The failing run_legacy jobs were not caused by the removed timeout vars; they were caused by CI still forcing debug/url-based plugin distribution across all Rust jobs while the CLI also coerced MOON_PLUGINS_USE_URL_DIST into PROTO_PLUGINS_USE_URL_DIST=true on mere presence. That combination masked the default ghcr.io path introduced by the proto/warpgate upgrade and made CI exercise the wrong bootstrap path.

  • What changed

    • Removed the temporary plugin distribution overrides from Rust CI so test jobs use the default registry-backed resolution path.
    • Fixed moon → proto env propagation so the proto flag preserves the actual boolean value instead of treating presence as true.
    • Kept the plugin bootstrap path aligned between moon and proto so CI now validates the intended post-upgrade behavior.
  • Why this matters

    • CI was validating a debug-only URL distribution path instead of the new default registry flow.
    • Falsey values like MOON_PLUGINS_USE_URL_DIST=false were still being converted into PROTO_PLUGINS_USE_URL_DIST=true, making local behavior and CI behavior diverge.
  • Behavioral change

    • Before, any presence of MOON_PLUGINS_USE_URL_DIST forced proto into URL mode.
    • Now, proto only follows the explicit boolean value.
if let Some(value) = bag.get("MOON_PLUGINS_USE_URL_DIST") {
    bag.set("PROTO_PLUGINS_USE_URL_DIST", value);
}

Copilot AI changed the title fix(plugin): add cross-process file lock for WASM plugin downloads to fix CI race on Windows fix(plugin): serialize concurrent WASM plugin downloads with a cross-process file lock Jun 2, 2026
Copilot finished work on behalf of milesj June 2, 2026 06:12
Copilot AI requested a review from milesj June 2, 2026 06:12
Copilot AI changed the title fix(plugin): serialize concurrent WASM plugin downloads with a cross-process file lock Fix CI plugin distribution overrides masking proto upgrade behavior Jun 2, 2026
Copilot finished work on behalf of milesj June 2, 2026 17:55
@milesj milesj closed this Jun 2, 2026
@milesj
milesj deleted the copilot/debug-ci-performance branch June 30, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants