Skip to content

fix: Audit 06/01 - #2550

Merged
milesj merged 20 commits into
masterfrom
fixes-0601
Jun 4, 2026
Merged

fix: Audit 06/01#2550
milesj merged 20 commits into
masterfrom
fixes-0601

Conversation

@milesj

@milesj milesj commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@milesj milesj changed the title Updates. fix: Audit 06/01 Jun 2, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 2, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 38.84%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
✅ 19 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime load_all 143.8 ms 102 ms +40.91%
WallTime hash_files[1000] 15.7 ms 11.2 ms +40.33%
WallTime load_many 60.1 ms 43.2 ms +38.98%
WallTime load_one 40.5 ms 30 ms +35.22%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fixes-0601 (b5b2450) with master (4ccc661)

Open in CodSpeed

@milesj
milesj marked this pull request as ready for review June 2, 2026 16:26
Copilot AI review requested due to automatic review settings June 2, 2026 16:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates daemon startup/readiness detection (with an eye toward improving Windows behavior) and ensures cache lock files are cleaned up when locks are released. It also records the changes in the changelog and refreshes a few dependency lockfile entries.

Changes:

  • Reworked DaemonConnector readiness polling to prefer “endpoint accepts connections” over PID-file-only readiness.
  • Updated cache locking so lock files under .moon/cache/locks are removed on unlock.
  • Added an Unreleased changelog entry and updated Cargo.lock.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
crates/daemon/src/connector.rs Changes how daemon readiness is detected after spawning, including child-process liveness checks.
crates/cache/src/cache_engine.rs Ensures lock files created by create_lock are removed on unlock.
crates/actions/src/utils.rs Updates hash-lock creation flow (currently redundantly calls remove_on_unlock).
CHANGELOG.md Documents the daemon readiness and lock cleanup fixes under Unreleased.
Cargo.lock Updates locked dependency versions/checksums.

Comment thread crates/daemon/src/connector.rs Outdated
Comment thread crates/daemon/src/connector.rs Outdated
Comment thread crates/actions/src/utils.rs Outdated
Comment thread crates/actions/src/utils.rs Outdated
@milesj
milesj merged commit 2378828 into master Jun 4, 2026
35 checks passed
@milesj
milesj deleted the fixes-0601 branch June 4, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants