fix: Audit 06/01 - #2550
Conversation
Merging this PR will improve performance by 38.84%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | load_all |
143.8 ms | 102 ms | +40.91% |
| ⚡ | WallTime | hash_files[1000] |
15.7 ms | 11.2 ms | +40.33% |
| ⚡ | WallTime | load_many |
60.1 ms | 43.2 ms | +38.98% |
| ⚡ | WallTime | load_one |
40.5 ms | 30 ms | +35.22% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing fixes-0601 (b5b2450) with master (4ccc661)
There was a problem hiding this comment.
Pull request overview
This PR updates daemon startup/readiness detection (with an eye toward improving Windows behavior) and ensures cache lock files are cleaned up when locks are released. It also records the changes in the changelog and refreshes a few dependency lockfile entries.
Changes:
- Reworked
DaemonConnectorreadiness polling to prefer “endpoint accepts connections” over PID-file-only readiness. - Updated cache locking so lock files under
.moon/cache/locksare removed on unlock. - Added an Unreleased changelog entry and updated
Cargo.lock.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/daemon/src/connector.rs | Changes how daemon readiness is detected after spawning, including child-process liveness checks. |
| crates/cache/src/cache_engine.rs | Ensures lock files created by create_lock are removed on unlock. |
| crates/actions/src/utils.rs | Updates hash-lock creation flow (currently redundantly calls remove_on_unlock). |
| CHANGELOG.md | Documents the daemon readiness and lock cleanup fixes under Unreleased. |
| Cargo.lock | Updates locked dependency versions/checksums. |
No description provided.