fix: Audit 06/18 - #2577
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates workspace alias handling and task output caching behavior, and includes a small Docker prune fix plus routine dependency/toolchain bumps across the Rust/WASM portions of the repo.
Changes:
- Allow aliases that are identical to a project ID to be stored on the project (while avoiding alias re-index collisions).
- Ensure output caching updates remote cache even when the
casOutputsCacheexperiment is disabled. - Bump built-in toolchain plugin locator versions and refresh
wasm/Cargo.lock.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| wasm/Cargo.lock | Updates WASM workspace dependency lockfile entries (new/updated transitive crates). |
| crates/workspace/src/workspace_builder.rs | Adjusts alias tracking to allow alias == project ID without conflicting with other IDs/aliases. |
| crates/workspace/src/projects_builder.rs | Mirrors alias tracking changes in the projects builder implementation. |
| crates/task-runner/src/output_archiver.rs | Refactors archiving flow to always save to CAS/remote, with legacy local archive only when CAS outputs cache is disabled. |
| crates/project-graph/tests/project_graph_test.rs | Updates test expectations to reflect alias == ID now being recorded on the project. |
| crates/config-loader/src/toolchains_config_ext.rs | Bumps default built-in toolchain plugin locator versions. |
| crates/app/src/commands/docker/prune.rs | Refactors Docker prune install package collection and adds unit tests. |
| CHANGELOG.md | Adds unreleased entries describing the fixes and toolchain changes. |
Comment on lines
+69
to
+81
| // Collect all outputs (streams each file directly into the CAS) | ||
| let outputs = self.collect_output_blobs(hash).await?; | ||
| let mut archived = !outputs.is_empty(); | ||
|
|
||
| // Store action + result in local and/or remote caches | ||
| self.save_in_cas(hash, state, outputs).await?; | ||
| // Store action + result in local and/or remote caches | ||
| self.save_in_cas(hash, state, outputs).await?; | ||
|
|
||
| return Ok(archived); | ||
| // Create the archive file (temporary) | ||
| if !state.local_cas_enabled { | ||
| archived = self.pack_local_archive(hash, state).await?; | ||
| } | ||
|
|
||
| // Create the archive file (temporary) | ||
| self.pack_local_archive(hash, state).await | ||
| Ok(archived) |
Comment on lines
+24
to
+32
| .flat_map(|project| { | ||
| project.aliases.iter().filter_map(|alias| { | ||
| if alias.plugin == toolchain_id { | ||
| Some(alias.alias.clone()) | ||
| } else { | ||
| None | ||
| } | ||
| }) | ||
| }) |
Comment on lines
+162
to
+165
| packages: get_install_packages_for_projects( | ||
| &instance.projects, | ||
| &toolchain.id, | ||
| ), |
Merging this PR will not alter performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.