Skip to content

internal: Improve daemon implementation. - #2597

Merged
milesj merged 12 commits into
develop-2.4from
2.4-daemon
Jul 3, 2026
Merged

internal: Improve daemon implementation.#2597
milesj merged 12 commits into
develop-2.4from
2.4-daemon

Conversation

@milesj

@milesj milesj commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Thanks to Fable.

@codspeed-hq

codspeed-hq Bot commented Jul 2, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 34.41%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 9 improved benchmarks
❌ 1 regressed benchmark
✅ 13 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime hash_files[1000] 11.3 ms 19 ms -40.42%
WallTime load_all 168.9 ms 102.2 ms +65.29%
WallTime load_one 46 ms 28 ms +64.41%
WallTime load_many 68.5 ms 41.8 ms +63.78%
WallTime get_file_hashes[1000] 6.9 ms 4.7 ms +47.36%
WallTime build_graphs_sync[1000] 549.1 ms 382 ms +43.75%
WallTime build_graphs_sync[100] 48.3 ms 34.8 ms +38.75%
WallTime get_file_hashes[100] 1.7 ms 1.2 ms +37.26%
WallTime build_graphs_async[1000] 102.3 ms 76.2 ms +34.21%
WallTime hash_files[100] 1.7 ms 1.3 ms +34.06%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing 2.4-daemon (439e564) with develop-2.4 (2b29272)

Open in CodSpeed

@milesj
milesj merged commit 28002be into develop-2.4 Jul 3, 2026
20 checks passed
@milesj
milesj deleted the 2.4-daemon branch July 3, 2026 16:11
milesj added a commit that referenced this pull request Jul 5, 2026
* Add log date.

* Phase 1.

* Run in background.

* Rework connection.

* Add acquire.

* Add version handshake.

* Clean up usage.

* Add monitoring.

* Add background tasks.

* Fix watcher.

* Fix shutdown.

* Fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant