new: Add workspace root level setup_environment and install_dependencies actions. - #2648
Merged
Conversation
Merging this PR will regress 2 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | hash_files[1000] |
9.8 ms | 15 ms | -34.92% |
| ❌ | WallTime | load_one |
28.3 ms | 40.4 ms | -30.02% |
| ⚡ | WallTime | build_graphs_async[1000] |
128 ms | 82.4 ms | +55.26% |
| ⚡ | WallTime | build_graphs_async[100] |
43 ms | 31.6 ms | +36.06% |
| ⚡ | WallTime | build_graphs_sync[1000] |
507.5 ms | 383.5 ms | +32.36% |
| ⚡ | WallTime | build_graphs_sync[100] |
46 ms | 34.9 ms | +31.9% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing 2.5-root-actions (cae91b3) with develop-2.5 (9c3f756)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds workspace root level
setup_environmentandinstall_dependenciessupport to the action graph, and wires environment setup intomoon setup.Action graph builder
install_dependencies_root(spec)andsetup_environment_root(spec)methods that are not associated with a project. They locate the dependencies root starting from the workspace root (workspace-level toolchain config only), and only insert actions when the located root is the workspace root — otherwise they insert nothing at all (noSyncWorkspace/SetupToolchainside effects) and returnNone. Nested dependency roots are expected to be handled by their owning projects.project_idand an empty root, so they dedupe with project-based installs that resolve to the workspace root.internal_install_dependencies/internal_setup_environmentmethods, with a sharedlocate_dependencies_roothelper covering both project and workspace starting points.Noneinstead of failing on a missing plugin function.Setup command
moon setupnow also sets up each configured toolchain's environment viasetup_environment_root, when its dependency root is the workspace root.Tests
setup_env,install_deps_root, andsetup_env_roottest suites for the builder, covering the root-matching gate, deps workspace members, dedupe with the project-based flow, tier gating, and pipeline action switches.🤖 Generated with Claude Code