fix: when FileCreationTime is blank use 0000#1778
Open
adamdecaf wants to merge 1 commit intomoov-io:masterfrom
Open
fix: when FileCreationTime is blank use 0000#1778adamdecaf wants to merge 1 commit intomoov-io:masterfrom
adamdecaf wants to merge 1 commit intomoov-io:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the overwriteDateTimeFields method to ensure a consistent "0000" value is set for FileCreationTime when it is missing or empty in JSON requests, preventing issues with wall clock time formatting. Corresponding tests were updated and a new test case was added. The review suggests using strings.TrimSpace to more robustly handle whitespace-only strings.
adamdecaf
force-pushed
the
fix-filecreation-time-overwrite
branch
from
d33076d to
fa57fcf
Compare
…n empty On read of a file if there's no FileCreationTime use 0000 instead of the wall clock time (when the blank is formatted). We can't get away with 000000 for FileCreationDate so make it the current day, which still allows for dedup across for a single day.
adamdecaf
force-pushed
the
fix-filecreation-time-overwrite
branch
from
fa57fcf to
02e295e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On read of a file if there's no FileCreationTime use 0000 instead of the wall clock time (when the blank is formatted).
If both Date and Time are empty use the wall clock time.
Context: https://moov-io.slack.com/archives/CD9J8EJKX/p1777017836830609