fix: non-greedy suite_name regex and remove re.DOTALL in _CASE_REGEX#1309
Open
Shraman123 wants to merge 1 commit into
Open
fix: non-greedy suite_name regex and remove re.DOTALL in _CASE_REGEX#1309Shraman123 wants to merge 1 commit into
Shraman123 wants to merge 1 commit into
Conversation
The greedy .+ in suite_name consumed all :: separators instead of stopping at the first one, causing nested test IDs to be mis-parsed. re.DOTALL was also unnecessary for single-line node IDs and risky when parametrize values contain embedded newlines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
_CASE_REGEXincorrectly parses nested pytest node IDs.The
suite_namegroup uses a greedy.+, which consumes the last::instead of the first.Example:
The
re.DOTALLflag is unnecessary for pytest node IDs (which are single-line)and can cause incorrect matches when parametrized values contain newlines.
Fix
suite_namenon-greedy (.+?)re.DOTALLImpact
Risk
Low — change is limited to regex parsing logic
Example
Before:
OuterClass::InnerClass::test_fn → suite_name = OuterClass::InnerClass ❌
After:
OuterClass::InnerClass::test_fn → suite_name = OuterClass ✅