Add structured MCP discovery and actionable tool contracts - #25
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
raw_queryescape hatch, concise and detailed pages, semantic references, query interpretation, warnings, and suggested actionsThe search contract keeps the deprecated
queryinput and detailed response format as compatibility defaults. Repository search remains a bounded metadata-only GitHub read.Evaluation decisions
The initial suite measures protocol calls, errors, response bytes, and polling calls through the real in-memory MCP transport. It does not claim model-selection or token-count results.
jobs.get: the baseline needs one submission and one poll, so it does not support consolidating job creation and polling.trendingoractivepresets need held-out model-backed or human-agent evidence and disclosed definitions.This follows the tool-design principles in Writing tools for agents while keeping the changes within the existing MCP architecture.
Compatibility and safety
querycalls continue to work and receive a deprecation warning.allOfintersections rendered opaquely in some clients.Suggested review order
internal/mcpserverinternal/appVerification
go test ./...go vet ./...go mod tidy -diffgit diff --check