fix(release): stop gating npm discovery on redundant npx round-trip - #288
Merged
Conversation
The 3.0.0 npm publish succeeded but the post-publish verifier failed because its third check re-resolved `gitcontribute@latest` through npx, re-downloading the 56 MB native tarball within a 30 s per-probe timeout. Right after publication, registry dist-tag propagation plus npx resolution routinely exceeded the 10-attempt/6 s window, so the job aborted and left the GitHub release without its tarball artifact. Public discoverability is a registry-metadata property already proven by `npm view` (dist-tags.latest + version resolution); the published binary is smoke-tested earlier in the job via the local tarball. Drop the npx round-trip, widen the retry budget (30 attempts, 5 s delay), and attach the npm tarball to the GitHub release whenever `npm publish` succeeded even if the discovery probe times out. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gitcontribute@latestthroughnpx, re-downloading the 56 MB native tarball within a 30 s per-probe timeout. Right after publication, registry dist-tag propagation + npx resolution exceeded the 10-attempt / 6 s window.npm view(dist-tags.latest+ version resolution); the published binary is smoke-tested earlier in the job via the local tarball. Removed the redundantnpxround-trip and widened the retry budget (30 attempts, 5 s delay).npm publishsucceeded (if: always() && steps.publish.outcome == 'success'), so a transient propagation delay can't leave the release incomplete.Test plan
npm run test:npm— 13/13 pass (updated the three publication-verification tests to drop thenpxcall expectation and adjust retry/timeout call counts 4 → 3)Generated with Devin