deps(deps): bump googleapis/release-please-action from 4.4.1 to 5.0.0 - #1002
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
5696f8a to
b4d5e40
Compare
|
Second-pass architecture review: merge-ready from my side. The Node 24 change is isolated to Release Please infrastructure and current CI was green in the earlier review. I would land this before refreshing #904 so the release PR is generated by the release machinery we actually intend to use. |
b4d5e40 to
eff75e2
Compare
morluto
left a comment
There was a problem hiding this comment.
Post-cutover architecture audit
Disposition: retain, rebase, and validate; not superseded.
Release Please Action v5.0.0 is still the latest tagged upstream release, while current main remains on v4.4.1. This dependency update is orthogonal to the Jacobian runtime simplification and should survive it.
Because v5 moves the action runtime to Node 24, rebase onto current main, verify that the pinned SHA is the official v5.0.0 tag commit, and run the release workflow on the current manifest/config with unchanged permissions, concurrency, and token behavior. Confirm that it can update or regenerate the post-cutover release PR cleanly rather than inheriting #1186’s obsolete pre-cutover release state.
If the dry run and normal CI pass, merge this before asking Release Please to generate the next release candidate.
eff75e2 to
1216c2f
Compare
|
Post-simplification review: keep, but rebase/update before merge. This is a release-workflow dependency change and does not conflict with the new mathematical/tool architecture. Because the branch only touches Recommendation: rebase, run the release workflow validation (or a safe equivalent), then merge independently. Do not combine it with generated release state from #1186. |
1216c2f to
5b53d24
Compare
morluto
left a comment
There was a problem hiding this comment.
Refresh complete
Dependabot’s branch has been refreshed onto the post-#1265 mainline. Current head: 6497293.
The PR remains a one-file, one-line workflow update from googleapis/release-please-action@4.4.1 to @5.0.0; it has no product-architecture overlap. CI, Benchmarks, and Container Image all completed successfully on the refreshed head.
morluto
left a comment
There was a problem hiding this comment.
Dependency update is current and green
This remains a one-file GitHub Actions update, is mergeable, and CI, Benchmarks, and Container Image all pass on head 6497293.
The Node 24 transition is contained inside the upstream action; Jacobian's workflow inputs and release configuration are unchanged.
Disposition: ready for normal dependency-update landing.
Bumps googleapis/release-please-action from 4.4.1 to 5.0.0.
Release notes
Sourced from googleapis/release-please-action's releases.
Changelog
Sourced from googleapis/release-please-action's changelog.
... (truncated)
Commits
45996edchore(main): release 5.0.0 (#1200)a8121b9chore: build dist (#1201)f533c26fix: bump release-please from 17.3.0 to 17.6.0 (#1199)46dfc01feat!: upgrade to node24 (#1188)