fix(eval): preserve incomplete observation evidence - #1312
Merged
Conversation
Contributor
Coverage ReportTotal coverage: 78% (threshold: 50%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
nullonly inINCOMPLETEobservation evidenceVALIDevidenceVALIDWhy
The documented
agent-eval-validatepath detects missing reproducibility bindings and builds anINCOMPLETEevidence payload, but then fails before writing it because the schema rejects the normalizer's explicitnullplaceholders. A completed 16-task paired Harbor evaluation reproduced this on current main. Operators lose the validation-failure record instead of receiving inspectable fail-closed evidence.This is separate from PR #1256 and does not authorize any causal or valid evidence claim.
Validation
benchmarks/validation/test_observation_artifact_binding.py: 19 passedmake quick: 870 passed after a one-time cold-import timeout was reproduced directly and passedmake check-static: passed