Fix Lean guard verifier negation parsing - #1315
Merged
Merged
Conversation
Contributor
Coverage ReportTotal coverage: 78% (threshold: 50%) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a30c03e9a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The controlled Round 3 Harbor evaluation produced mathematically equivalent control and treatment findings for
lean-guard-scope-assurance, but only the treatment answer was rejected. Its sentence—“The universal order guard does not supply a sound nonzero divisor fact, so the divisor remains semantically zero.”—correctly preserves the benchmark's unsafe-division conclusion.The verifier's broad
not ... divisorregular expression treated that valid wording as if it denied division by zero. This was a localized alternative-valid-representation verifier bug; the treatment made no Jacobian calls.Safety and impact
The change only narrows a wording heuristic. Existing fail-closed checks for claims that division by zero is safe, impossible, or cannot occur remain intact. It does not change Jacobian behavior, mathematical semantics, benchmark inputs, or assurance authority.
PR #1256 was checked before publication. It changes the runtime architecture but does not touch this benchmark or its verifier, so there is no overlap.
Validation
lean-guard-scope-assurance: passed, including static checks, contracts, 12 generic security tests, focused tests, and Oracle validationmake check-static: passedgit diff --check: passed