TEMP: sync main into P-recursive table port - #1323
Conversation
* fix(lean): remove unchanged corrupt declaration caches * test(lean): cover corrupt declaration-cache cleanup * style(lean): format corrupt-cache regressions
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
* fix(probability): canonicalize Gaussian sparse inputs * fix(probability): own Gaussian request canonicalization * fix(probability): preserve canonical request round trips * test(probability): replay canonical Gaussian requests * docs(probability): distinguish raw and canonical bounds --------- Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
* fix(topology): preserve non-maximal facet diagnostics * test(external-sat): remove stale producer conclusions * ci: shard ordinary Python checks by semantic lane
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
92d180b
into
agent/port-p-recursive-table-residuals-v2
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 413e3846c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return replace( | ||
| operation, | ||
| spec=replace( | ||
| operation.spec, | ||
| request_type=CanonicalGaussianPolynomialMomentRequest, |
There was a problem hiding this comment.
FINITE_PROBABILITY_CAPABILITIES already declares this operation with CanonicalGaussianPolynomialMomentRequest in operations.py, so rebuilding its OperationSpec here creates a second owner for the same request contract and hides the concrete InstalledOperation type behind Any. Remove this patching helper and keep the request type solely in the operation declaration, as required for ordinary operations.
AGENTS.md reference: AGENTS.md:L108-L114
Useful? React with 👍 / 👎.
| The claim is bound to canonical input and candidate digests, graph semantics, | ||
| checker identity, checker source digest, and provider runtime. | ||
| The verifier does not certify a directly supplied graph, an unbounded graph |
There was a problem hiding this comment.
For callers of the diameter and radius verifiers, this paragraph now correctly says that verification binds submitted input and candidate digests, but the immediately following sentence still says the verifier does not certify a directly supplied graph. ExactComputedVerificationRequest and _validated_inline_payloads accept exactly that submitted {input, candidate} form, so the reference gives mutually exclusive descriptions of the supported route; revise the disclaimer to exclude only different inputs, unbounded families, and derived theorems.
AGENTS.md reference: AGENTS.md:L186-L189
Useful? React with 👍 / 👎.
2 participants
Temporary branch synchronization for #1285. Merge current
maininto the feature branch only if conflict-free.