TEMP: sync latest main into real-quadratic port - #1352
Conversation
* refactor(tests): finish pytest-owned suite architecture * fix(tests): include exhaustive lane in full CI reproduction * fix(ci): avoid full benchmarks for root Makefile changes * fix(ci): release superseded runs before aggregate gates
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bca4f71e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name: required | ||
| if: ${{ always() }} | ||
| needs: [static, python, boundaries, wheel, coverage, lean, optional-providers] | ||
| if: ${{ always() && !cancelled() }} |
There was a problem hiding this comment.
If the current PR workflow is manually or API-cancelled after an upstream lane fails but before this aggregator starts, !cancelled() prevents the required job from inspecting the failed/cancelled needs results. The downstream branch-protection mirror jobs use the same condition, so they are condition-skipped rather than producing a failing required check; GitHub treats condition-skipped jobs as successful for required-check purposes. Keep always() on the aggregation and mirror jobs so cancellation remains fail-closed, while retaining cancellation guards only on non-gating cleanup or artifact steps.
Useful? React with 👍 / 👎.
1 participant
Temporary synchronization after #1316 for #1287.