TEMP: advance finite-abelian port onto latest checker-runtime base - #1362
Conversation
* test: narrow runtime fixture ownership * perf(checkers): batch installation identity measurement
Compose declaration-owned clean-process runtimes with the latest batched checker-identity path. Existing checker families retain the legacy registry; new declarations may carry one unassigned provider runtime, and the composition root batches identity material across the full declaration set before authorization.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
4cddde2
into
agent/port-finite-abelian-factorization-v2
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
jacobian/src/jacobian/exact_domain_checkers.py
Lines 283 to 288 in 2b4f61d
Omit unavailable declaration-owned optional runtimes
For a declaration backed by an unavailable optional native or formal provider, _provider_runtime_key() always produces a declaration:... key, which can never belong to _OPTIONAL_EXACT_REPLAY_PROVIDER_KEYS. Consequently this branch calls CheckerInstaller.install(..., authorize=True) with an unavailable runtime; CheckerRegistry.authorize() rejects it, aborting construction of the entire application rather than omitting only that verifier capability. Handle availability for declaration-owned runtimes before attempting authorization.
AGENTS.md reference: AGENTS.md:L219-L221
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "operator-authorized Python-FLINT exact replay independent of the " | ||
| "SymPy producer" | ||
| ) | ||
| provider_runtime: CapabilityProviderRuntime | None = None |
There was a problem hiding this comment.
When a domain populates this field with source_provider_runtime, as the new unit test demonstrates, package-source hashing happens while the bundle is constructed. build_builtin_portfolio() constructs those declarations before install_domain_verification() reaches the authorization batch, so ordinary startup with checker authority disabled would still perform the expensive checker identity measurement. Keep an unmeasured provider specification in the declaration and resolve its measured runtime at the authorization boundary instead.
AGENTS.md reference: AGENTS.md:L137-L140
Useful? React with 👍 / 👎.
1 participant
Temporary stack synchronization after #1357. Merge latest
agent/domain-owned-checker-runtimesinto #1301 only if conflict-free.