Rank integer factorization for prime-power queries - #2028
Rank integer factorization for prime-power queries#2028yuelgrace1810-ops wants to merge 1 commit into
Conversation
|
CI note: the failing tooling/coverage/required checks reproduce the missing pre-#2019 documentation path already present on this branch base. Draft PR #2029 fixes that path-only current-main regression and is fully green. I have intentionally not duplicated #2029 into this discovery-only branch; after #2029 lands, updating this branch should clear those unrelated failures. |
morluto
left a comment
There was a problem hiding this comment.
Review verdict: no correctness blocker found
This is a narrow discovery fix: the revised description truthfully states that the operation returns a complete prime-power factorization, and the regression exercises the public search result rather than an internal score. It does not alter the factorization kernel or wire contract.
As with #2024, the exact matches[0] assertion is mildly brittle if another legitimate integer-factorization operation is later added with equally strong phrase coverage. A durable property would assert that integer.compute.prime_factorization ranks ahead of unrelated operations for this query. That is nonblocking; the current change correctly fixes the reported discoverability gap.
81f9305 to
74f1fa7
Compare
|
Addressed the review observation: the regression now checks that factorization precedes the three unrelated prime-navigation operations, without requiring an absolute first position forever. The branch is rebased onto current main after #2029 and |
Problem
On current
main, the natural queryfactor an integer into prime powersranked three neighboring prime-navigation operations aboveinteger.compute.prime_factorization. The exact factorization operation scored 43 and appeared fourth, even though its contract was the directly applicable operation.This is a concrete vocabulary gap of the kind discussed in closed issue #1059: maintainers preferred small, held-out metadata fixes over a new search architecture.
Solution
MathTooldescription.The property-style regression does not require factorization to remain absolute position zero if a future legitimate factorization operation is added, addressing the maintainer's review concern.
The change affects discovery metadata only. It does not alter factorization mathematics, request bounds, result contracts, or search semantics.
Validation
mainafter merged Fix references to the moved agent evaluation guide #2029.24 passed.make check:1,309 passed; Ruff, formatting, complexity, and mypy passed.Overlap
MathToolmetadata correction.