fix(schema): always meta-validate generated schemas - #579
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #577 skipped Draft 2020-12 meta-schema validation for selected Pydantic-generated schemas. Its replacement trust classifier inspected
__pydantic_core_schema__metadata to distinguish default generation from custom output.That is not a stable ownership boundary. Pydantic supports schema replacement and mutation through model methods, field extras,
WithJsonSchema, nested types, custom core schemas, custom generators, and JSON-schema hooks. Tracking those internal representations recreates part of Pydantic's schema-generation machinery and can miss version-specific customization paths.Change
register_model()result through the existingregister()boundary_validated_schema, so each exact schema is meta-validated and compiled once per processWithJsonSchemaoutput are rejected before descriptor persistenceThis follows python-jsonschema's documented boundary: validate the schema itself, construct the validator, then reuse that validator for payloads.
Validation
uv run --locked pytest -n 0 tests/component/schemas— 18 passedThe runtime-construction performance concern remains valid, but should be addressed through initialization/publication/lazy-loading ownership rather than by weakening schema validation.