Skip to content

Route SAT and SMT recovery diagnostics through public capabilities - #609

Merged
morluto merged 3 commits into
mainfrom
agent/audit-capability-composition
Aug 7, 2026
Merged

Route SAT and SMT recovery diagnostics through public capabilities#609
morluto merged 3 commits into
mainfrom
agent/audit-capability-composition

Conversation

@yuelgrace1810-ops

@yuelgrace1810-ops yuelgrace1810-ops commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • replace SAT and SMT recovery hints that named internal artifact-service methods with public math.find capability routes
  • explain which optional solver provider is required for assignment or proof production
  • explicitly tell callers not to invent artifact URIs
  • add regression coverage for invalid SAT assignment and SMT proof recovery guidance

Root cause

Verifier and solver diagnostics were exposed through public capability results, but their remediation text instructed agents to call internal Python service methods that are not available through MCP. Evaluation exposed this first for SAT; a repository-wide literal-hint audit then found the same independent pattern in SMT proof verification.

Audit evidence

A combined capability-composition and diagnostic-actionability audit checked:

  • 134 literal public diagnostic hints for internal APIs and capability references
  • producer-to-verifier continuity
  • discovery reachability
  • invocation-example correctness
  • capability relationship integrity
  • packaged-surface parity

All 328 installed capability titles were rediscoverable in the top five, all 224 published invocation examples completed, 42 emitted relationships resolved to stored artifacts, and the two packaged skill surfaces were byte-identical. The actionable internal-API references were isolated to SAT and SMT recovery hints.

Overlap review

Validation

  • SAT focused tests: 15 passed
  • focused Ruff lint and formatting: passed
  • git diff --check: passed
  • SMT regression is included in the existing Linux/provider test lane. On this macOS host, that file retains its pre-existing Carcara runtime-provenance failures because the pinned external checker is unavailable; 3 provider-independent cases pass locally. No provider or assurance behavior was changed.

This is intentionally a draft PR and does not change SAT/SMT mathematics, assurance, artifact validation, or provider installation policy.

@yuelgrace1810-ops
yuelgrace1810-ops force-pushed the agent/audit-capability-composition branch from 47f29df to 075e71e Compare August 7, 2026 03:44
@yuelgrace1810-ops yuelgrace1810-ops changed the title Route SAT recovery diagnostics through public capabilities Route SAT and SMT recovery diagnostics through public capabilities Aug 7, 2026
@morluto
morluto marked this pull request as ready for review August 7, 2026 06:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50ff4ca587

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

hint=(
"Create the assignment with SatArtifactService.put_assignment "
"against the intended canonical CNF."
"Use math.find for sat.model.find to produce an assignment "

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Invoke artifact producers with math.run

When an invalid assignment URI triggers this diagnostic, following the hint only inspects sat.model.find: math.find is read-only discovery and cannot produce the promised assignment artifact. The same misleading wording appears in the new CNF and SAT/SMT proof hints. Direct callers to the public MCP surface therefore remain unable to complete the stated recovery unless they already know to make a separate math.run call; explicitly say to inspect the producer with math.find and execute it with math.run, or point directly to math.run.

AGENTS.md reference: AGENTS.md:L58-L62

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in ce16268: recovery hints now say "inspect with math.find and execute with math.run" instead of just "use math.find", so callers can complete the stated artifact recovery.

math.find is read-only discovery and cannot produce assignment or proof
artifacts. Update recovery hints to say 'inspect with math.find and
execute with math.run' so callers can complete the stated recovery.
@morluto
morluto merged commit ed202ef into main Aug 7, 2026
39 checks passed
@morluto
morluto deleted the agent/audit-capability-composition branch August 7, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants