Split verifier support and hard-gate evidence rewards - #615
Merged
Conversation
morluto
marked this pull request as ready for review
August 7, 2026 06:32
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
load_submission was rejecting schema-invalid submissions before scoring, which collapsed correctness and hid false VERIFIED claims. Parse the submission object for diagnostics, leave schema checks to the contract helpers, and align adapter/legacy public-contract host validation. Co-authored-by: morluto <morluto@users.noreply.github.com>
Evidence is now a hard reward gate. Update host validations that still expected soft evidence bonuses, and keep protocol/evidence failures from collapsing independent mathematical correctness. Co-authored-by: morluto <morluto@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa6a565754
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ema load" This reverts commit da32ee3.
# Conflicts: # benchmarks/datasets/research-diagnostics-v1/jcb-postdoc-015/tests/Dockerfile # benchmarks/datasets/research-diagnostics-v1/jcb-postdoc-016/tests/Dockerfile
This was referenced Aug 7, 2026
cursor Bot
pushed a commit
that referenced
this pull request
Aug 7, 2026
#615 landed load_submission_raw and reverted weakening load_submission, which had collapsed host-verifier expectations (correctness staying 1.0 on envelope-only failures). Resolve conflicts by adopting main's tree so this branch matches the supported diagnostic split. Co-authored-by: morluto <morluto@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shared verifier validation modules had become large mixed-ownership hotspots, and mathematical benchmark rewards could still encode evidence as a soft additive term. That representation obscured the fail-closed invariant and made future verifier-policy migrations easier to get wrong.
Closes #500.
Closes #538.
Solution
Split the mathematical-benchmark and public-reproduction validation support into behavior-owned modules for fixtures, metadata, paths, verifier execution, evidence binding, input binding, assurance, and submission attacks.
Migrate the affected benchmark verifiers to hard-gate invalid evidence before reward aggregation. Remove redundant evidence terms from four remaining counterexample verifiers, strengthen the reward ratchet to recognize the
evalias, and synchronize the affected verifier checksum labels.Testing
The ratchet reported 2 passing tests and the four affected verifier modules reported 5 passing tests. Earlier focused validation of the support split reported 1,699 mathematical-benchmark checks and 11 public-reproduction checks passing.
Trust & Compatibility Impact
This changes evaluation integrity behavior: invalid evidence now contributes zero reward rather than being represented inside a weighted aggregate. It does not authorize checkers or promote evaluator output to verified evidence. The support split preserves the existing public validation facade.
Checklist
make check)