fix(runtime): preserve bootstrap failures when cleanup fails - #724
Merged
Conversation
cursor
Bot
force-pushed
the
agent/preserve-bootstrap-failure-676
branch
from
August 7, 2026 15:50
9d4848e to
1861d55
Compare
morluto
marked this pull request as ready for review
August 7, 2026 15:59
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If runtime bootstrap fails after opening its artifact store and
ArtifactRepository.close()also raises, the cleanup exception replaces the original construction error. Users then see a secondary teardown fault instead of the startup root cause.Fixes #676.
Solution
Keep cleanup best-effort inside the existing bootstrap exception path. When closing the store also fails, attach that secondary failure as an exception note and re-raise the original exception unchanged.
The regression closes a real store before injecting the cleanup error, so it proves both resource release and exception precedence rather than bypassing cleanup.
Testing
The regression failed on
mainby raisingOSError: store close failureinstead of the injected primaryRuntimeError.Result: the regression passed and preserved the cleanup error in
__notes__; Ruff, formatting, and diff checks passed. The planner conservatively selects broader product lanes for the transitively imported bootstrap path; those draft-PR checks are pending.Trust & Compatibility Impact
No verification, checker authorization, artifact, protocol, or public API contract changes. Only dual-failure exception reporting changes; a cleanup-only failure is still raised normally.
Checklist
make check)