Accept materialized posets for linear-extension counts - #787
Closed
yuelgrace1810-ops wants to merge 4 commits into
Closed
Accept materialized posets for linear-extension counts#787yuelgrace1810-ops wants to merge 4 commits into
yuelgrace1810-ops wants to merge 4 commits into
Conversation
morluto
marked this pull request as ready for review
August 8, 2026 17:34
Owner
|
Closing as superseded by #884 / commit bb6adc8. Current main deliberately replaced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
LinearExtensionRequestaccept exactly one of an inline canonical poset or a materialized-poset artifact URI;poset.finite.materializetoposet.linear_extensions.countthrough the repository's existing typed artifact converter boundary;Root cause and evaluation evidence
The harder 24-run routing study found that the agent discovered
poset.linear_extensions.count, but the operation could not consume the artifact produced byposet.finite.materialize. It attempted to reconstruct the opaque canonical poset manually and failed on element ordering, transitive reduction, ranks, and digest binding: 13 MCP calls, eight errors, 304,743 input tokens, and no completed expected capability.With the exact contract-inspection Skill fix alone, the run improved to seven calls but still failed. With this artifact-composition fix plus that guidance, the same task completed successfully in six calls and 59.8 seconds, using the materialized result URI rather than reconstructing canonical internals.
Overlap
Merged PR #619 established this typed materialization path for
poset.width.compute, butposet.linear_extensions.countwas not connected. This PR reuses that infrastructure and does not introduce a new artifact system.Safety
Artifact retrieval, schema identity, semantics identity, and conversion remain owned by
MaterializedOperationAdapter. Inline requests remain supported. The checker accepts only an inline poset with a null artifact URI and still rejects artifact-only claims it cannot independently resolve. No mathematical algorithm, count, assurance level, or checker authority changes.Validation
git diff --checkpassed