perf(mcp): cache MCP tool argument names - #801
Merged
Merged
Conversation
morluto
marked this pull request as ready for review
August 8, 2026 07:06
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #737.
Change
Derive each tool’s accepted argument names once from the extension’s existing
tools()bindings during initialization. Request interception now uses that immutable map instead of rebuilding bindings and inspecting handlers for every call.The public tool definitions remain the single source of truth, including the reasoning-enabled
math.runsignature. Unknown unregistered tool names now take the adapter’s invalid-input error path if they reach the interceptor directly; normal MCP dispatch rejects them before that point.Coverage
The tool-surface tests cover the stable OFF mode plus the reasoning identifiers required by the enabled
math.runhandler. The MCP SDK conformance test exercises unknown-argument rejection through a live client/server call.Validation
make test-unit TESTS=tests/unit/tooling/test_mcp_tool_surface.py— 6 passedmake test-mcp TESTS=tests/boundary/mcp/test_mcp_sdk_2_conformance.py— 2 passedmake check-static— passedmake npm-test— 45 passed