refactor(core): use SymPy for plugin matrix algebra - #802
Merged
Conversation
morluto
marked this pull request as ready for review
August 8, 2026 04:34
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
morluto
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #706 and #699.
Change
Replace the matrix reference plugin’s handwritten Fraction Gaussian elimination and row-echelon routines with narrow adapters to SymPy’s maintained exact
Matrix.det()andMatrix.nullspace()operations. The plugin continues to expose standard-libraryFractionvalues at its wire boundary.The adapter explicitly converts SymPy numerators and denominators before constructing each
Fraction, preserving exact rational output without relying on third-party numeric-conversion behavior. Empty-matrix behavior is retained.Scope
This intentionally leaves the certified-SNF and finite-field matrix code unchanged: their algorithms have different domain and certificate requirements.
Validation
make test-component TESTS=tests/component/plugins/test_matrix_plugin.py— 14 passeduv run ruff check src/jacobian/plugins/matrices.py tests/component/plugins/test_matrix_plugin.py— passeduv run mypy src/jacobian/plugins/matrices.py— passed