Fail closed without polynomial checker identity - #811
Merged
Conversation
morluto
marked this pull request as ready for review
August 8, 2026 04:28
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #732.
Verification adapters previously used
assert checker_id is not None. Those guards disappear under optimized Python.This change makes missing checker identity explicit: construction fails with an installation invariant error, while invocation fails through the existing structured diagnostic path. The normal installation gate remains unchanged.
Regression coverage constructs both adapters with an intentionally missing checker identity and verifies they reject the invalid state.
Validation:
make test-component TESTS=tests/component/providers/polynomial/test_polynomial_positivity_capabilities.pymake test-domain TESTS=tests/domain/polynomial/test_polynomial_interval_capabilities.pymake lint-full