Clarify finite partition verification scope - #918
Merged
Conversation
morluto
marked this pull request as ready for review
August 9, 2026 08:37
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 888065a6a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
morluto
force-pushed
the
agent/clarify-finite-partition-scope
branch
from
August 9, 2026 08:54
888065a to
8894880
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
case.partition.finitetreats universe members and case labels as opaque caller-supplied stringsCloses #914.
Root cause
A held-out weak-model evaluation correctly used the finite partition checker but promoted its verification record to the entire mathematical answer. The record established coverage and disjointness of a caller-constructed string universe; it did not establish that the universe was mathematically exhaustive or that its strings and case labels had the claimed semantics.
The checker, artifact bindings, and assurance decision were correct. The missing piece was a sufficiently explicit statement of that semantic boundary in the operation card and the successful result.
Trust and compatibility
This does not change the checker, verification record, accepted inputs, output schema, or
VERIFIEDeligibility. It changes descriptive model-visible text only.Validation
make check: Ruff, formatting, complexity, mypy, 869 unit tests passedgit diff --check: passed