Clarify inline verifier invocation envelopes - #929
Conversation
|
Additional held-out reproduction on current main (2026-08-09): a |
|
Post-#924 recovery evidence (2026-08-09): the same weak-model configuration ( |
|
Branch validation against the original frozen |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b42d08c468
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b42d08c to
c4ae444
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4ae4443db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ce090e268
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Second-pass architecture review: rebase + likely merge. This survives the post-#956 architecture well: it exposes the concrete transport shape of an already-declared producer/verifier relationship without prescribing verification timing or research strategy. The earlier reasoning-ID concern is obsolete because #956 removed the production reasoning-mode schema. The later review hardening around typed invocation-protocol models, explicit producer relationships, and |
# Conflicts: # src/jacobian/domains/polynomial/checkers.py # tests/boundary/mcp/test_mcp_adapter.py
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8f9fbd8e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a70e7c800
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
morluto
left a comment
There was a problem hiding this comment.
Post-cutover architecture audit
Disposition: revise substantially; retain the invocation-example goal.
The observed payload-shape failure is valid, but this implementation derives a new MCP invocation_protocol projection from a deleted producer relationship and schema heuristics. That recreates transport-specific metadata and another source of truth.
On current main, put a concrete {capability_id, payload: {input, candidate}} invocation example directly on each applicable checker OperationSpec/descriptor. Exact inspection already returns the full descriptor, so no synthetic projection or relationship test is needed. Correct the syzygy description at the checker declaration, add one generic invariant that advertised examples validate against math.run, and delete all relationship/projection code from this branch.
|
Architecture review after #1256/#1265: superseded as an implementation; keep the usability problem and solve it through current descriptor examples. The observed failure is valid: inline replay checkers with sibling Current exact inspection already has authoritative request schemas and bounded, operator-authored Recommendation: do not rebase this patch. Replace it with a much smaller current-main change adding validated invocation examples to the affected checker descriptors (and an MCP inspection regression), then close #929 as superseded. |
Superseded by typed ports, operation examples, and current lineage cleanupClosing this pre-cutover implementation rather than rebasing its generic projection heuristic. The reproduced failure was real, but the surviving solution is now split across current ownership boundaries:
This branch inferred an Disposition: root cause retained; implementation superseded. |
What changed
math.runinvocation envelope for inline replay verifiers in both discovery results and full contract inspection.inputandcandidateare sibling fields insidepayload.Why
A held-out weak-model evaluation using the exact degree-8 binary partition-polynomial log-concavity counterexample found the correct Jacobian syzygy immediately, but then spent 408 seconds and failed two verifier calls. The model first nested
candidateinsideinput, then placed it besidepayload. Both invalid shapes are plausible readings of a contract that had no invocation example and contradictory stored-versus-inline wording.This change exposes transport shape without prescribing mathematical strategy, making producer-to-verifier replay easier and reducing avoidable validation retries.
Validation
make test-unit— 869 passedmake test-component— 759 passed, 3 skippedmake test-domain— 185 passedmake test-mcp— 46 passedmake test-e2e— 8 passed, 1 skippedmake check-static— passed, including lint, format, dependency, type, architecture, and build checksmake npm-testcould not run becausenpmis not installed on this host.