fix(release): let release PR updates trigger CI - #470
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release-please currently mutates its pull request with the workflow
GITHUB_TOKEN. GitHub deliberately placespull_requestworkflows caused by that token intoaction_required, so every release-PR update needs a manual workflow approval before required checks can run.Use a dedicated
RELEASE_PLEASE_TOKENfor both mutations of the release branch: the release-please action and the follow-up canonical catalog commit. Keeping the same identity for both pushes is essential; otherwise the catalog normalization commit reintroduces the approval gate. The existingGITHUB_TOKENremains a transition fallback, preserving today’s manual-approval behavior until the dedicated credential is provisioned.The intended credential is a narrowly scoped GitHub App installation token, or a fine-grained PAT with repository contents and pull-request write access. The locally configured broad classic PAT was intentionally not copied into Actions.
Type of Change
Testing Performed
npm run typecheck)npm run lint)npm run format:check -- .github/workflows/release.yml— passedgit diff --check— passedTool Contract Impact
None.
Related Issues
Observed on release PR #463.