Fix AttributeError when telemetry is disabled (#176)#177
Merged
ArnavAgrawal03 merged 1 commit intoJun 3, 2025
Merged
Conversation
Bug ReportName: AttributeError when telemetry is disabled Comments? Email us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #176
This PR ensures that metadata extractors are initialized even when telemetry is disabled. Previously, the
_initialize()method returned early before setting upingest_file_metadataand other attributes, leading toAttributeError.Changes
_setup_metadata_extractors()to run unconditionally before theTELEMETRY_ENABLEDcheck.Testing
AttributeErrorno longer occurs when telemetry is disabled.Let me know if you'd like any changes!