[Certora] Precise calculation of earliestExecutionTime()#906
Open
[Certora] Precise calculation of earliestExecutionTime()#906
Conversation
Collaborator
Author
|
I now believe that the only reason why the current code verifies (even the current main branch) is because the loop unrolling depth is too low for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the spec EarliestTime and tracks the
minDecreaseTimelockvalues precisely.I still get a counterexample when for decreaseTimelock(). Apparently there is something strange in the prover, as the counterexample doesn't even enter the if statement in the hook.
Disclaimer: I also noticed that the traces for the sanity check are wrong, in the sense that they compute the signature incorrectly. It looks like this problem already existed before. I opened a ticket for the Certora prover to investigate this.