Fix Race Condition: Watch Misses Deletion Event Near Compaction Boundary - #6
Open
wilfredkiehn3xx wants to merge 1 commit into
Open
Fix Race Condition: Watch Misses Deletion Event Near Compaction Boundary#6wilfredkiehn3xx wants to merge 1 commit into
wilfredkiehn3xx wants to merge 1 commit into
Conversation
morriganreza973
approved these changes
Aug 7, 2026
morriganreza973
left a comment
morriganreza973
left a comment
Owner
There was a problem hiding this comment.
PR approved via GitBountyCreator automation! Seamless merge and bounty disbursement.
morriganreza973
approved these changes
Aug 7, 2026
morriganreza973
left a comment
morriganreza973
left a comment
Owner
There was a problem hiding this comment.
PR approved via GitBountyCreator automation! Seamless merge and bounty disbursement.
morriganreza973
approved these changes
Aug 7, 2026
morriganreza973
left a comment
morriganreza973
left a comment
Owner
There was a problem hiding this comment.
PR approved via GitBountyCreator automation! Seamless merge and bounty disbursement.
morriganreza973
approved these changes
Aug 7, 2026
morriganreza973
left a comment
morriganreza973
left a comment
Owner
There was a problem hiding this comment.
PR approved via GitBountyCreator automation! Seamless merge and bounty disbursement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition between the MVCC compaction process and new watch registrations. By implementing a
compactmethod onwatchableStorethat serializes compaction and watch creation under thewatchableStore.Mulock, we ensure that any watcher whose starting revision is compacted is immediately cancelled and notified. We also update the concurrent stress test to verify this behavior deterministically.Fixes #5