Skip to content

Revert "MOSIP-44198"#265

Merged
ckm007 merged 1 commit into
release-1.3.xfrom
revert-249-MOSIP-08-signoff
May 12, 2026
Merged

Revert "MOSIP-44198"#265
ckm007 merged 1 commit into
release-1.3.xfrom
revert-249-MOSIP-08-signoff

Conversation

@dhanendra06

@dhanendra06 dhanendra06 commented May 12, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Version upgraded to 1.3.1-develop
    • Updated container image source and registry
    • Optimized memory resource allocation from 3000Mi to 2500Mi
    • Enhanced JVM startup configuration with performance tuning flags
    • Refactored service startup process for improved deployment consistency

Review Change Stack

This reverts commit 223f0d1.

Signed-off-by: Dhanendra Sahu <60607841+dhanendra06@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 12, 2026

Copy link
Copy Markdown

Caution

Review failed

Failed to post review comments

Walkthrough

This PR coordinates the 1.3.1 release by bumping Maven versions across build modules, refactoring Docker startup to use a dedicated bootstrap script for downloading the auth adapter, and updating Helm deployment with new image coordinates, memory tuning, and JVM configuration flags.

Changes

Audit Manager 1.3.1 Release

Layer / File(s) Summary
Maven project version alignment
kernel/pom.xml, kernel/kernel-auditmanager-api/pom.xml, kernel/kernel-auditmanager-service/pom.xml
Root pom.xml and module versions bumped from 1.3.0 to 1.3.1-SNAPSHOT; kernel dependency properties (kernel.core.version, kernel.applicant-type.version, kernel.audit-api.version, kernel.logger.version, kernel-dataaccess-hibernate-version) updated to 1.3.1-SNAPSHOT in kernel-auditmanager-service.
Docker startup refactoring with bootstrap script
kernel/kernel-auditmanager-service/configure_start.sh, kernel/kernel-auditmanager-service/Dockerfile
New configure_start.sh script with fail-fast mode that downloads kernel-auth-adapter.jar from environment-provided URL and delegates to the passed command; Dockerfile updated to copy the script with executable permissions and use it as ENTRYPOINT, simplifying CMD to only start the audit manager jar with loader and Spring properties.
Helm deployment configuration and image updates
deploy/install.sh, helm/auditmanager/Chart.yaml, helm/auditmanager/values.yaml
Helm chart version bumped to 1.3.1-develop; install script updated to reference new chart version; values.yaml updated image repository to mosipqa/kernel-auditmanager-service and tag to 1.3.x, reduced memory request to 2500Mi, and replaced basic heap configuration with multi-flag JVM options including ZGC tuning.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A whisker-twitch, a version change—
From 1.3.0 to 1.3.1, rearrange!
Maven, Docker, Helm align,
The bootstrap script marks the line.
ZGC tuning makes it fly,
Audit manager reaches the sky! 🚀

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Revert "MOSIP-44198"' is vague and does not clearly describe what changes are being made in the changeset without consulting external references. Replace the title with a more descriptive summary of the actual changes, such as 'Revert audit manager configuration changes' or reference the specific changes like 'Revert version updates and container configuration changes'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-249-MOSIP-08-signoff

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dhanendra06 dhanendra06 changed the base branch from master to release-1.3.x May 12, 2026 12:42
@ckm007 ckm007 merged commit f809420 into release-1.3.x May 12, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants