Skip to content

Added server profile design doc in eSignet#2115

Open
Md-Humair-KK wants to merge 1 commit into
mosip:developfrom
Infosys:ES-ServerProfile
Open

Added server profile design doc in eSignet#2115
Md-Humair-KK wants to merge 1 commit into
mosip:developfrom
Infosys:ES-ServerProfile

Conversation

@Md-Humair-KK

@Md-Humair-KK Md-Humair-KK commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Documentation
    • Added a comprehensive design guide for the new Server Profile feature.
    • Documented global profile settings, startup behavior, and how effective security settings are resolved.
    • Included supported profile values, database schema details, example configurations, and guidance for introducing new profiles.
    • Added notes covering enforced behaviors for key OpenID/FAPI security features and backward compatibility.

Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b9f250b6-ba71-4082-8862-08dee9113228

📥 Commits

Reviewing files that changed from the base of the PR and between db78d05 and 4c85b97.

📒 Files selected for processing (1)
  • docs/design/server-profile.md

Walkthrough

A new design document docs/design/server-profile.md is added, describing the Server Profile feature: a global deployment toggle controlling OIDC/FAPI security enforcement, including DB schema, configuration property, runtime resolution logic, PAR/PKCE/DPoP enforcement, and backward compatibility notes.

Changes

Server Profile Design Document

Layer / File(s) Summary
Server profile design doc
docs/design/server-profile.md
Adds complete design document covering the mosip.esignet.server.profile toggle, server_profile DB table schema and seed rows, feature-to-config-key mapping, per-transaction resolution priority, PAR/PKCE/DPoP enforcement rules, instructions for adding custom profiles, and backward compatibility notes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

A rabbit hops through FAPI lands,
with PAR and PKCE in its hands,
the server profile sets the stage,
a single toggle, neatly caged.
🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a server profile design document to eSignet.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant