[mosip/mosip-infra#1890] Added domainConfig support in helm charts

[bhumi46]

Summary

Cherry-pick of #1988 from develop onto release-1.8.x: adds domainConfig support in the esignet helm charts (deployment.yaml and values.yaml), replacing esignet-global with a generic domainConfig values mechanism.

Original commit: 429c6cb

Test plan

• Verify helm template renders domainConfig env vars correctly
• Verify no regression for deployments without domainConfig set

Summary by CodeRabbit

• New Features
  • Added support for providing additional application environment settings through deployment configuration.
  • Introduced a new configurable values entry for supplying key/value pairs at install or upgrade time.

[coderabbitai]

Walkthrough

This PR adds a new domainConfig value to the Helm chart's values.yaml and updates deployment.yaml to iterate over domainConfig entries, injecting each key/value pair as a container environment variable.

Changes

Helm domainConfig env injection

Layer / File(s)	Summary
domainConfig value and env loop helm/esignet/values.yaml, helm/esignet/templates/deployment.yaml	Adds an empty domainConfig map to values.yaml and a template block in deployment.yaml that ranges over it, rendering each key as an env var name and quoted value.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

• mosip/esignet#1988: Both PRs add the same domainConfig iteration logic to deployment.yaml and the same domainConfig: {} entry to values.yaml.

Suggested reviewers: ckm007, anushasunkada

Poem

A map once empty, now holds keys so bright,
Each domain value hopping into env just right.
🐇 With a quote and a loop, the chart springs alive,
No more hardcoded fields to strive.
Hop, hop, deploy — the config's in flight!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding domainConfig support to the Helm charts.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@helm/esignet/templates/deployment.yaml`:
- Around line 125-128: Document that domainConfig entries are expected to be
scalar/string values because the deployment template’s range over domainConfig
uses quote for each $val and will stringify non-scalar maps/lists incorrectly;
update the chart’s values documentation around domainConfig to state the
expected type clearly and, if needed, reference the deployment template’s
domainConfig loop so consumers know to avoid nested objects.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8729538c-01a6-432a-80f9-8225ba613b5a

📥 Commits

Reviewing files that changed from the base of the PR and between 8998875 and 4ea8616.

📒 Files selected for processing (2)

• helm/esignet/templates/deployment.yaml
• helm/esignet/values.yaml

[coderabbitai]

📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Document expected value type for domainConfig.

{{ $val | quote }} assumes scalar values. If a consumer sets a domainConfig entry to a map/list, quote will stringify Go's default map/list representation into the env value, which is unlikely to be the intended output. Consider documenting (in values.yaml) that entries must be string/scalar values.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@helm/esignet/templates/deployment.yaml` around lines 125 - 128, Document that
domainConfig entries are expected to be scalar/string values because the
deployment template’s range over domainConfig uses quote for each $val and will
stringify non-scalar maps/lists incorrectly; update the chart’s values
documentation around domainConfig to state the expected type clearly and, if
needed, reference the deployment template’s domainConfig loop so consumers know
to avoid nested objects.