[MOSIP-43498] Added properties to configure the wait time between gen…

[Ivanmeneges]

…erating UIN/VID in apitestrigs helm chart

Added configuration properties for eSignet API Test Rigs, including wait times and retry attempts.

Summary by CodeRabbit

• Chores
  • Added new deployment configuration parameters for UIN and VID processing: configurable delay times and a maximum retry count for UIN availability checks. Included descriptive comments for each setting to clarify expected wait intervals and retry behavior. No functional logic changes were made.

[coderabbitai]

Walkthrough

Three new Helm values were added to helm/apitestrig/values.yaml: uinGenerationProcessingDelayTimeInMilliSeconds, vidGenerationProcessingDelayTimeInMilliSeconds, and uinGenMaxLoopCount, defining wait durations and a max retry count for UIN/VID generation processes.

Changes

Cohort / File(s)	Change Summary
Helm Configuration Updates helm/apitestrig/values.yaml	Added three new configuration properties: uinGenerationProcessingDelayTimeInMilliSeconds: '90000', vidGenerationProcessingDelayTimeInMilliSeconds: '90000', and uinGenMaxLoopCount: '20', with comments describing wait times and retry limits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Simple addition of configuration keys and comments; no code logic changes.
• Files to spot-check: helm/apitestrig/values.yaml for correct key names, types (strings), and comment clarity.

Poem

I nibble lines of YAML bright,
I set the waits and retries right,
Ninety seconds, loops of twenty, too —
UINs and VIDs, a tidy queue. 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly matches the changeset—adding properties to configure wait time between UIN/VID generation in the Helm chart values file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c02f68a and dd927ac.

📒 Files selected for processing (1)

• helm/apitestrig/values.yaml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• helm/apitestrig/values.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: build-maven-authentication-demo-service / maven-build
• GitHub Check: build-maven-apitest-commons / maven-build
• GitHub Check: chart-lint-publish / chart-lint-publish
• GitHub Check: Analyze (java-kotlin)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

helm/apitestrig/values.yaml (1)

500-509: Consider using unquoted numeric values for consistency.

The three new configuration properties use quoted strings ('90000', '20') to represent numeric values. Verify whether this aligns with codebase conventions—if the consuming application expects actual numeric types or if other similar numeric configuration properties in this Helm chart are unquoted. If numeric representation is standard elsewhere in the codebase or values file, consider using unquoted numbers for clarity and to let YAML type inference handle the conversion.

Example alternative format:

uinGenerationProcessingDelayTimeInMilliSeconds: 90000
vidGenerationProcessingDelayTimeInMilliSeconds: 90000
uinGenMaxLoopCount: 20

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61cca0c and c02f68a.

📒 Files selected for processing (1)

• helm/apitestrig/values.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: chart-lint-publish / chart-lint-publish
• GitHub Check: Analyze (java-kotlin)
• GitHub Check: build-maven-apitest-commons / maven-build

🔇 Additional comments (1)

helm/apitestrig/values.yaml (1)

500-509: Configuration properties added correctly with clear documentation.

The three new properties are well-positioned within the apitestrig.configmaps.apitestrig section, indentation is consistent with adjacent configuration keys, and each property includes a descriptive comment. The values (90-second delays and 20 retry attempts) appear reasonable for API test rig processing tolerances. YAML structure is valid.